Skip to content

Fix divison #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix divison #240

wants to merge 1 commit into from

Conversation

mrkn
Copy link
Member

@mrkn mrkn commented Nov 13, 2022

This will fix #222.

Now `BigDecimal(5) / 9` isn't correctly rounded on half down mode.
We need to fix `VpMidRound` and/or `VpLeftRound` for correct rounding.
@jeffktan
Copy link

jeffktan commented May 7, 2025

Following up on this PR as it causes slowness in our codebase. It may cause slowness many!

@mrkn
Copy link
Member Author

mrkn commented May 29, 2025

#329 fixes the problem.

@mrkn mrkn closed this May 29, 2025
@mrkn mrkn deleted the fix_div branch May 29, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exponential growth in precision causing memory usage to spike as of 3.1.2
2 participants